From john.tourtellott at kitware.com Thu May 3 11:51:07 2018 From: john.tourtellott at kitware.com (John Tourtellott) Date: Thu, 3 May 2018 11:51:07 -0400 Subject: [Smtk-developers] Is RGG requried by SMTK's vtk extension? Message-ID: We recently pushed MR !1108 to remove some RGG dependencies and change the default SMTK__ENABLE_RGG_SESSION to "off", however I just learned that RGG is much more tightly coupled into to SMTK that I realized. In particular, the vtk extension file vtkAuxiliaryGeometryExtension.cxx uses RGG code, so that the vtk extension is dependent on the rgg extension. I have not looked into this in any detail, as I am trying to get a build ready for SLAC this afternoon, but I want to pose the question - Can re revise the vtk extension to *not* be dependent on rgg? - If not, then I'll update the CMake files to make this dependency explicit. -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.thompson at kitware.com Thu May 3 12:00:24 2018 From: david.thompson at kitware.com (David Thompson) Date: Thu, 3 May 2018 12:00:24 -0400 Subject: [Smtk-developers] Is RGG requried by SMTK's vtk extension? In-Reply-To: References: Message-ID: <8FFD6B48-B1EC-4920-9FA4-85507D6D200F@kitware.com> Hi John, > We recently pushed MR !1108 to remove some RGG dependencies and change the default SMTK__ENABLE_RGG_SESSION to "off", however I just learned that RGG is much more tightly coupled into to SMTK that I realized. In particular, the vtk extension file vtkAuxiliaryGeometryExtension.cxx uses RGG code, so that the vtk extension is dependent on the rgg extension. I have not looked into this in any detail, as I am trying to get a build ready for SLAC this afternoon, but I want to pose the question > ? Can re revise the vtk extension to not be dependent on rgg? I am shocked that this dependency crept in. Yes, it should definitely be removed. At least one way to remove it is to add another class like vtkAuxiliaryGeometryExtension that _only_ provides ".rgg" files. The way smtk::common::Extensions work is that if one extension cannot handle a file, the next one is tried. David From john.tourtellott at kitware.com Thu May 3 12:38:28 2018 From: john.tourtellott at kitware.com (John Tourtellott) Date: Thu, 3 May 2018 12:38:28 -0400 Subject: [Smtk-developers] Is RGG requried by SMTK's vtk extension? In-Reply-To: <8FFD6B48-B1EC-4920-9FA4-85507D6D200F@kitware.com> References: <8FFD6B48-B1EC-4920-9FA4-85507D6D200F@kitware.com> Message-ID: Thanks, David. It sounds like we should have Haocheng make an update when he gets back. For now, I'll hack around it for the SLAC build. On Thu, May 3, 2018 at 12:00 PM, David Thompson wrote: > Hi John, > > > We recently pushed MR !1108 to remove some RGG dependencies and change > the default SMTK__ENABLE_RGG_SESSION to "off", however I just learned that > RGG is much more tightly coupled into to SMTK that I realized. In > particular, the vtk extension file vtkAuxiliaryGeometryExtension.cxx uses > RGG code, so that the vtk extension is dependent on the rgg extension. I > have not looked into this in any detail, as I am trying to get a build > ready for SLAC this afternoon, but I want to pose the question > > ? Can re revise the vtk extension to not be dependent on rgg? > > I am shocked that this dependency crept in. Yes, it should definitely be > removed. At least one way to remove it is to add another class like > vtkAuxiliaryGeometryExtension that _only_ provides ".rgg" files. The way > smtk::common::Extensions work is that if one extension cannot handle a > file, the next one is tried. > > David -------------- next part -------------- An HTML attachment was scrubbed... URL: From haocheng.liu at kitware.com Thu May 3 14:51:15 2018 From: haocheng.liu at kitware.com (Haocheng Liu) Date: Thu, 3 May 2018 14:51:15 -0400 Subject: [Smtk-developers] Is RGG requried by SMTK's vtk extension? In-Reply-To: References: <8FFD6B48-B1EC-4920-9FA4-85507D6D200F@kitware.com> Message-ID: I'm back. I would fix it. -------------- next part -------------- An HTML attachment was scrubbed... URL: