[Smtk-developers] SMTK build error

[David Thompson]

> MR closed.

Thanks, Rob.

	David

> 
> On Wed, Jun 1, 2016 at 5:45 PM, David Thompson
> <david.thompson at kitware.com> wrote:
>> Hi Rob,
>> 
>>> The shared_ptr test never compiling is orthogonal to the shiboken
>>> issue so that is why I broke it out into a separate MR.
>> 
>> But we cannot merge both of them because MR 94 addresses both. It is a tiny fix and I would rather not spend more time on it. Do you really think it's important to rewrite MR 94?
>> 
>>        David
>> 
>>> 
>>> On Wed, Jun 1, 2016 at 5:34 PM, David Thompson
>>> <david.thompson at kitware.com> wrote:
>>>>> Here is the MR that fixes the issue ( that I created ):
>>>>> https://gitlab.kitware.com/cmb/smtk/merge_requests/95
>>>> 
>>>> Umm... I submitted a similar MR here:
>>>> 
>>>> https://gitlab.kitware.com/cmb/smtk/merge_requests/94
>>>> 
>>>> that also fixes things in the event that boost shared pointers are used. The issue I don't want to deal with is figuring out how to avoid explicitly specifying the template parameter...
>>>> 
>>>>       Sorry,
>>>>       David
>>>> 
>>>>> 
>>>>> On Wed, Jun 1, 2016 at 5:04 PM, David Thompson
>>>>> <david.thompson at kitware.com> wrote:
>>>>>>> Can you open an issue that provides / points me towards how the newer
>>>>>>> clang compilers are failing the c++11 check for shared ptr?
>>>>>>> 
>>>>>>> That is something that should work going forward.
>>>>>> 
>>>>>> 
>>>>>> Here's the error message:
>>>>>> 
>>>>>> Trying shared ptr; result: Change Dir: /Stage/Build/SMTK/polygon/CMakeTmp/CMakeFiles/CMakeTmp
>>>>>> 
>>>>>> Run Build Command:"/usr/local/bin/ninja" "cmTC_e0daa"
>>>>>> [1/2] Building CXX object CMakeFiles/cmTC_e0daa.dir/shared_ptr.cxx.o
>>>>>> FAILED: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++     -std=c++11  -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk -mmacosx-version-min=10.10 -o CMakeFiles/cmTC_e0daa.dir/shared_ptr.cxx.o -c /Stage/Source/SMTK/polygon/CMake/shared_ptr.cxx
>>>>>> /Stage/Source/SMTK/polygon/CMake/shared_ptr.cxx:14:30: error: no matching function for call to 'make_shared'
>>>>>> std::shared_ptr<float> f = std::make_shared(42.0f);
>>>>>>                           ^~~~~~~~~~~~~~~~
>>>>>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:4747:1: note: candidate template ignored: couldn't infer template argument '_Tp'
>>>>>> make_shared(_Args&& ...__args)
>>>>>> ^
>>>>>> 1 error generated.
>>>>>> ninja: build stopped: subcommand failed.
>>>>>> 
>>>>>> If you really think it's worth an issue, feel free to open one but please don't assign it to me. :-)
>>>>>> 
>>>>>>      David
>>>> 
>>