[Smtk-developers] Warnings

[Robert Michael O'Bara]

I'm ok with either approach.

Bob

Sent from my iPad

> On Aug 27, 2015, at 5:15 PM, David Thompson <david.thompson at kitware.com> wrote:
> 
> We could also use pragmas around VTK includes to turn off C++11 warnings. We do something similar for other 3rd party libraries.
> 
>    David
> 
>> On Aug 27, 2015, at 5:13 PM, Ben Boeckel <ben.boeckel at kitware.com> wrote:
>> 
>> On Thu, Aug 27, 2015 at 12:52:33 -0400, Robert Michael O'Bara wrote:
>>> /Users/obara/Projects/Kitware/Builds/CMBSuperBuild/smtk/src/smtk/smtk/model/Session.h:200:36: note: 
>>>     expanded from macro 'smtkDeclareModelingKernel'
>>> smtkDeclareOperatorRegistration();
>>>                                  ^
>> 
>> These would need a style change to SMTK.
>> 
>>> /Users/obara/Projects/Kitware/Builds/CMBSuperBuild/paraview/src/paraview/VTK/Common/Core/vtkType.h:225:16: warning: 
>>>     'long long' is a C++11 extension [-Wc++11-long-long]
>>> typedef signed long long   vtkTypeInt64;
>> 
>> ...
>> 
>>> 1310 warnings generated.
>>> Linking CXX shared module ../../../lib/smtkRemoteSessionPython.so
>> 
>> SMTK is setting -std=c++11, but VTK headers are not warning-clean in such a
>> situation. SMTK should either use "SYSTEM" as the first argument when adding
>> VTK/ParaView include directories or not set C++11 as its target.
>> 
>> --Ben
>> _______________________________________________
>> Smtk-developers mailing list
>> Smtk-developers at smtk.org
>> http://public.kitware.com/mailman/listinfo/smtk-developers
>